Ensure the address is valid on server init #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkjt2000
requested changes
Jan 26, 2022
Co-authored-by: Kevin Tindall <kevinkjt2000@users.noreply.github.com>
Source: https://stackoverflow.com/a/106223/2607949 Co-authored-by: Kevin Tindall <kevinkjt2000@users.noreply.github.com>
kevinkjt2000
approved these changes
Jan 27, 2022
Collaborator
|
Thanks again! |
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189
As shown in the issue, not having any checks for valid values of the server's address can lead to the instance being made without any hint of an error, even though it has unexpected internal values which will be causing issues later. Whenever this happens, since the error will only appear in later usage of this instance, It will not be easy to recognize what's going on. To prevent this, this PR adds a function which simply raises an exception during initialization if the values aren't valid, therefore preventing even the creation of an instance with invalid values.
Note: I've also used regex to ensure that the host address is valid, however I'm not entirely sure if this pattern catches all possible host values correctly, so please make sure to test this before approving the PR.