Drop support for python 3.6 #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183
As described in the issue, python 3.6 has reached end of life and support for it should be dropped.
Note: Dropping 3.6 also allows for some code-base improvements such as the use of dataclasses and other features which was also mentioned in the issue. This PR does NOT implement any of these changes since I feel like that should be left for other specific pull requests with this one only dropping the support for the version itself. However, since this isn't a particularly pressing PR to get merged, if requested, I'm fine with implementing these improvements in here along with dropping it from supported versions, perhaps to avoid forgetting about doing it.