Make toast fully tappable #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Dimillian merged 1 commit into main from codex/fix-tap-area-on-toast-notification

Jan 4, 2026

Owner

Dimillian commented Jan 4, 2026

Motivation

The toast hit area was effectively limited to the label, making taps on the rest of the toast ignored and resulting in poor UX.
The intent is that tapping anywhere on the toast should trigger its action and dismissal.
Apply a minimal change to expand the tappable region without altering behavior.

Description

Added .contentShape(Rectangle()) to the ToastView instance in Packages/DesignSystem/Sources/DesignSystem/Views/ToastOverlayView.swift to expand the hit area.
Preserved the existing .onTapGesture which invokes the toast action.handler() and calls toastCenter.dismiss(id:).
No other behavior, layout, or animation changes were made.

Testing

No automated tests were run for this change.
Builds/tests were not executed in this environment because XcodeBuildMCP was not available.


          Make toast fully tappable

bd86469

Dimillian added the codex label

— with

ChatGPT Codex Connector

Dimillian merged commit 5139785 into main

2 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels