feat(messages): add file-link context menu with reveal#81
feat(messages): add file-link context menu with reveal#81Dimillian merged 4 commits intoDimillian:mainfrom
Conversation
|
@codex review this pr |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69dcc5228e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await MenuItem.new({ | ||
| text: "Open Link in New Window", | ||
| action: async () => { | ||
| await openFileLink(rawPath); | ||
| }, |
There was a problem hiding this comment.
The new context menu item labeled “Open Link in New Window” executes the exact same action as “Open Link” (openFileLink(rawPath)), so users will never get a distinct new-window behavior. Because openFileLink ultimately delegates to open_workspace_in (which just calls open -a <app> <path>), this menu item is misleading and provides no added functionality; consider removing it or wiring a separate command/flag (e.g., open -n -a on macOS) to match the label.
Useful? React with 👍 / 👎.
|
@codex any other issue with this PR? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccb923bdc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await MenuItem.new({ | ||
| text: "Open Link in New Window", | ||
| action: async () => { | ||
| await openFileLink(rawPath); | ||
| }, |
There was a problem hiding this comment.
The new context-menu item labeled “Open Link in New Window” invokes the same openFileLink action as the regular open item, so it performs the exact same operation and does not open a new window. This is user-visible misbehavior: when users rely on opening in a separate window to keep their existing editor state intact, this option won’t do that because it calls the same handler. Consider wiring this to a distinct code path (e.g., a new backend command or different app args) or removing the label until the behavior exists.
Useful? React with 👍 / 👎.
2 participants
No description provided.