refactor(ui): centralize event subscriptions#55
Merged
Dimillian merged 3 commits intoDimillian:mainfrom Jan 15, 2026
Merged
Conversation
a7d252f to
8370b9a
Compare
Contributor
Author
|
Rebased onto latest The branch should now be mergeable cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR1 from the RFC/design discussion in #54.
What
UI-only refactor (no intended behavior changes).
src/services/events.tsto centralize event subscriptions.src/features/app/hooks/useAppServerEvents.tssrc/features/terminal/hooks/useTerminalSession.tsto use the new subscription helpers.
Why
For an optional "remote backend" mode (e.g. WSL2 daemon + native Windows UI), we need the UI to be able to swap the event source (Tauri
listen(...)today, WebSocket tomorrow) without rewriting multiple hooks/components.This PR moves the event wiring behind a small service module so later work can introduce alternate implementations in one place.
Notes
app-server-event,terminal-output).Validation
npm cinpm run typechecknpm run build