Skip to content

Comments

fix: bundle daemon sidecars in app build#506

Draft
vforsh wants to merge 3 commits intoDimillian:mainfrom
vforsh:fix/bundle-daemon-sidecars
Draft

fix: bundle daemon sidecars in app build#506
vforsh wants to merge 3 commits intoDimillian:mainfrom
vforsh:fix/bundle-daemon-sidecars

Conversation

@vforsh
Copy link
Contributor

@vforsh vforsh commented Feb 24, 2026

Summary

  • bundle codex_monitor_daemon and codex_monitor_daemonctl via bundle.externalBin
  • add scripts/build-tauri-sidecars.sh to build and stage sidecar binaries before Tauri bundling
  • wire sidecar preparation into beforeBuildCommand
  • document behavior in README and ignore generated src-tauri/binaries/

Notes

  • this fixes app bundles missing the daemon binary required by codex_monitor_daemonctl

@vforsh
Copy link
Contributor Author

vforsh commented Feb 24, 2026

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad44bf9cd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

package.json Outdated
"prebuild": "npm run sync:material-icons",
"build": "tsc && vite build",
"build:appimage": "NO_STRIP=1 tauri build --bundles appimage",
"build:tauri-sidecars": "sh scripts/build-tauri-sidecars.sh",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run sidecar build script with bash

The new build:tauri-sidecars script invokes sh scripts/build-tauri-sidecars.sh, but build-tauri-sidecars.sh is written for Bash (set -euo pipefail, arrays, [[ ... ]], BASH_SOURCE). On systems where /bin/sh is not Bash (e.g. Ubuntu dash), this command fails immediately (set: Illegal option -o pipefail), so the sidecar build entrypoint added in this commit is unusable and cannot prepare binaries when called directly.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e27036e. I replaced the shell-only sidecar step with a cross-platform Node script (scripts/build-tauri-sidecars.mjs) and updated both build:tauri-sidecars and beforeBuildCommand to use it, so this no longer depends on Bash or ./...sh on Windows.

@vforsh vforsh marked this pull request as draft February 24, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant