feat(settings): add shortcut search bar in Shortcuts section#419
Merged
Dimillian merged 3 commits intoDimillian:mainfrom Feb 12, 2026
Merged
Conversation
Add a searchable filter input to Settings > Shortcuts so users can quickly find and edit shortcut bindings in large lists. What changed: - Added a "Search shortcuts" input above shortcut groups. - Implemented live filtering across group metadata and shortcut item labels/help text. - Added a clear action for the search query and a no-results empty state message. - Added a SettingsView test that verifies filtering and the no-match state. - Updated settings stylesheet with dedicated spacing for the new search field. Version bump: - Bumped app version from 0.7.51 to 0.7.52 across package.json/package-lock.json, src-tauri/Cargo.toml, src-tauri/Cargo.lock, src-tauri/tauri.conf.json, and iOS Info.plist.
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings > Shortcuts0.7.51to0.7.52across release version filesValidation
npm run typecheck(pass)npm run test -- src/features/settings/components/SettingsView.test.tsx(fails in local env due jsdom/parse5 ESM issue)npm run lint(fails in local env due missingis-extglobmodule in node_modules)