fix: windows threads and terminal#413
Conversation
fix:windows threads and terminal
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
|
@Dimillian now everything is fixed on the latest version |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21afbfa6fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| export function normalizeRootPath(value: string) { | ||
| return value.replace(/\\/g, "/").replace(/\/+$/, ""); | ||
| const normalized = value.trim().replace(/\\/g, "/").replace(/\/+$/, ""); |
There was a problem hiding this comment.
normalizeRootPath now calls value.trim(), which removes leading/trailing whitespace that can be part of a valid workspace directory name on Unix-like filesystems. This collapses distinct paths (for example, /tmp/repo vs /tmp/repo ) to the same normalized key, so thread filtering can attribute threads to the wrong workspace or hide them when matching by cwd.
Useful? React with 👍 / 👎.
| return `${normalized.charAt(0).toLowerCase()}${normalized.slice(1)}`; | ||
| } | ||
| if (normalized.startsWith("//")) { | ||
| return normalized.toLowerCase(); |
There was a problem hiding this comment.
Lowercasing the entire UNC path (normalized.toLowerCase()) makes path comparison unsafe on case-sensitive UNC backends (for example Samba/WSL shares configured as case-sensitive), where //server/share/Repo and //server/share/repo can be different directories. With the current normalization, those distinct workspaces become indistinguishable and thread lists can bleed across them.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21afbfa6fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| export function normalizeRootPath(value: string) { | ||
| return value.replace(/\\/g, "/").replace(/\/+$/, ""); | ||
| const normalized = value.trim().replace(/\\/g, "/").replace(/\/+$/, ""); |
There was a problem hiding this comment.
normalizeRootPath now calls trim(), which collapses distinct filesystem paths that differ only by leading/trailing spaces. In environments where those names are valid (for example POSIX workspaces like /tmp/repo vs /tmp/repo ), listThreadsForWorkspace and loadOlderThreadsForWorkspace compare these normalized values and can attribute threads to the wrong workspace because both normalize to the same string.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
fix: codex suggestions
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c1850cffc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Dimillian
changed the title
|
I'll look into it soon |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
2 participants
Fixed with the last version. Threads are refreshing properly getting all the threads from codex/vs code. Also terminal working