Conversation
Dimillian
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cd65a7676
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (threadId) { | ||
| markProcessing(threadId, false); | ||
| markReviewing(threadId, false); | ||
| setActiveTurnId(threadId, null); |
There was a problem hiding this comment.
Do not clear activeTurnId when item/tool/requestUserInput arrives, because the turn is still in progress and only paused for user response. Clearing it here causes later controls to lose the real turn id: interruptTurn falls back to "pending" when activeTurnIdByThread is null (useThreadMessaging.ts), and the real-id retry path only runs on a future onTurnStarted (useThreadTurnEvents.ts), which usually does not fire again for the same paused turn. In practice, after submitting user input, the resumed turn can no longer be reliably interrupted/steered.
Useful? React with 👍 / 👎.
1 participant
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task