Fix codex app-server spawn environment and init timeout#10
Closed
RaistlinMuc wants to merge 1 commit intoDimillian:mainfrom
Closed
Fix codex app-server spawn environment and init timeout#10RaistlinMuc wants to merge 1 commit intoDimillian:mainfrom
RaistlinMuc wants to merge 1 commit intoDimillian:mainfrom
Conversation
RaistlinMuc
force-pushed
the
fix/codex-app-server-env
branch
from
8f62fdb to
a06f1fe
Compare
Author
|
Closing for now; keeping changes in our fork first. |
Owner
|
Not ready yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Strip DYLD_* environment variables when spawning the codex app-server on macOS to avoid library leakage.\n- Remove node_modules/.bin entries from PATH when using the default codex binary so npm-run wrappers don't shadow the real install.\n- Add a 5s timeout for the initialize request and extra debug logging for stdout/stderr + exit status.\n\n## Motivation\nWhen running via npm scripts, PATH prepends node_modules/.bin and can resolve an unrelated codex script, causing the app-server to exit immediately and the UI to show "request canceled". DYLD_* vars from cargo can also poison child processes.\n\n## Testing\n- Not run (local environment).