Repository navigation
Remove the Browser card from the surface picker #3
Description
Activity
Resolution
Browser is gone from the "Open a surface" grid. Branch
feat/remove-browser-surface-card, commit5a792664f, unpushed. Net −10 lines in one file.Removed the
Browserentry fromRightPanelEmptyState'sactionsarray, plus the now-unusedonAddBrowserandbrowserAvailableprops on that component and the two lines passing them.Everything else about Browser is untouched, as scoped: the
+menu entry, the sixpreview.*keybindings,addBrowserSurface.ts, thepreviewsurface kind, and existing open browser surfaces.Globe2,SURFACE_DISABLED_REASONS.browser,browserAvailable, andonAddBrowserall remain live on the parent component, which the+menu still uses — no dead code left behind. Left a comment at the component explaining why Browser is absent from the grid but present in the menu, so it does not read as an oversight.Verified:
tsc -p apps/web/tsconfig.jsonclean,vp lintclean on the file,rightPanelStore.test.ts27 passed. No test covers the picker's card list directly.One correction and one consequence
Correction: during charting I described the picker as five cards including Plan. It was four — Browser, Terminal, Files, Diff. There is no Plan card;
ClipboardListis only the plan surface's tab icon.Consequence worth a look: the grid is
grid-cols-2, so it went from a clean 2×2 to three cards — two on top, one orphaned bottom-left. Adding 3D Watch Agent restores a clean 2×2; adding 3D Diff as well makes it five and ragged again. Not addressed here, since this ticket is scoped to the removal and the layout question belongs with whatever lands the new cards.No browser verification was run —
AGENTS.mdwants explicit sign-off for that, and this is a static change with a clean typecheck. Happy to do atest-t3-apppass on request.
Part of #1
Question
Drop the Browser entry from the
actionsarray inapps/web/src/components/RightPanelTabs.tsx(~line 100), so it no longer appears in the "Open a surface" grid.Scope is the card only. The
+dropdown (RightPanelTabs.tsx:449), the sixpreview.*keybindings (packages/contracts/src/keybindings.ts:59-64),addBrowserSurface.ts, and thepreviewsurface kind all stay. Rationale: this keeps divergence frompingdotgg/t3codenear zero, and Browser costs nothing at runtime on web.Explicitly not doing the general "hide unavailable cards" refactor. Showing a disabled card with a tooltip is intentional — it tells the user the feature exists and why they can't use it. Browser is a one-off removal, not a policy change.
Resolved when the card is gone from the grid,
rightPanelStore.test.tsand anyRightPanelTabstests still pass, and nothing else about Browser has moved.