Skip to content

Conversation

Copy link

Copilot AI commented Nov 15, 2025

Plan to reorder MinGW messages and set MINGW_BUILD in CMakeLists.txt:

  • Understand the current state of CMakeLists.txt MinGW block
  • Update the MinGW block to use if(MINGW) instead of generator match
  • Add MSYS detection message
  • Reorder so set(MINGW_BUILD ...) comes after MSYS detection
  • Verify the change doesn't break the build
  • Request code review
  • Run security checks
  • Complete the task
Original prompt

Update CMakeLists.txt to reorder the MinGW block so that the set(MINGW_BUILD TRUE CACHE INTERNAL "Building with MinGW") call comes after the MSYS detection. Current patch (from PR #720) changed the generator check to use if(MINGW) and added MSYS detection, but left set(MINGW_BUILD ...) before the MSYS if-block. Modify the file so the block reads exactly as follows (preserve indentation and newlines):

if(MINGW)
message("Building with MinGW")
if(MSYS)
message(" in MSYS environment")
endif()
set(MINGW_BUILD TRUE CACHE INTERNAL "Building with MinGW")
endif()

Make only this reordering change in CMakeLists.txt. Ensure the rest of the file is unchanged. If possible, apply the change to the branch used by the existing PR (#720) or create a new pull request to the DiligentGraphics/DiligentCore repository that implements this change. Include a concise commit message: "Reorder MinGW messages and set MINGW_BUILD in CMakeLists.txt".

This pull request was created as a result of the following prompt from Copilot chat.

Update CMakeLists.txt to reorder the MinGW block so that the set(MINGW_BUILD TRUE CACHE INTERNAL "Building with MinGW") call comes after the MSYS detection. Current patch (from PR #720) changed the generator check to use if(MINGW) and added MSYS detection, but left set(MINGW_BUILD ...) before the MSYS if-block. Modify the file so the block reads exactly as follows (preserve indentation and newlines):

if(MINGW)
message("Building with MinGW")
if(MSYS)
message(" in MSYS environment")
endif()
set(MINGW_BUILD TRUE CACHE INTERNAL "Building with MinGW")
endif()

Make only this reordering change in CMakeLists.txt. Ensure the rest of the file is unchanged. If possible, apply the change to the branch used by the existing PR (#720) or create a new pull request to the DiligentGraphics/DiligentCore repository that implements this change. Include a concise commit message: "Reorder MinGW messages and set MINGW_BUILD in CMakeLists.txt".


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants