Skip to content

Binance - Support specifying the network for withdrawals #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Binance - Support specifying the network for withdrawals #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ExchangeSharp/API/Exchanges/BinanceGroup/BinanceGroupCommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,11 @@ ExchangeWithdrawalRequest withdrawalRequest
payload["addressTag"] = withdrawalRequest.AddressTag;
}

if (!string.IsNullOrWhiteSpace(withdrawalRequest.Network))
{
payload["network"] = withdrawalRequest.Network;
}

JToken response = await MakeJsonRequestAsync<JToken>(
"/capital/withdraw/apply",
BaseUrlSApi,
Expand Down
9 changes: 7 additions & 2 deletions src/ExchangeSharp/Model/ExchangeWithdrawalRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,13 @@ public sealed class ExchangeWithdrawalRequest
/// </summary>
public SecureString Code { get; set; }

/// <summary>Returns a <see cref="System.String" /> that represents this instance.</summary>
/// <returns>A <see cref="System.String" /> that represents this instance.</returns>
/// <summary>
/// Network to use for the withdrawal
/// </summary>
public string Network { get; set; }

/// <summary>Returns a <see cref="string" /> that represents this instance.</summary>
/// <returns>A <see cref="string" /> that represents this instance.</returns>
public override string ToString()
{
// 2.75 ETH to 0x1234asdf
Expand Down