A Travesty! (First bug encountered V0.39, yes I compiled it)

[crispeeweevile]

A very unfortunate event has occurred in Lego City today, it with a heavy heart that I must announce... The ability to change from simple pin type does not work :p I didn't really do anything special to encounter this, all I was doing was making "new" encoders (basically just a passthrough the the already existing ones so I can rename them,) but in the process I learned that the ability to change pin type is broken. This is completely- fine. Please fix it whenever you can, but I don't know that anybody's day will be ruined by this fact.

[AOx0]

It should be disabled for groups, and enabled for single pins.
Does it work for single pins?

[AOx0]

NVM, I see the problem. Thanks for the feedback :/

[crispeeweevile]

NVM, I see the problem. Thanks for the feedback :/

Thanks for getting back to me so quickly :) Hopefully it will be a really quick solution without much to do.

[AOx0]

@VitoBarra I think tracked down the issue to commit c2dbe38 in file Assets/Scripts/Interaction/ChipInterfaceEditor.cs

Here:

-        if (selectedSignals.Count == 0)
+        if (IsSomethingSelected)

IsSomethingSelected (always?) returns early

Digital-Logic-Sim-CE/Assets/Scripts/Interaction/ChipInterfaceEditor.cs

Lines 131 to 132 in 6465028

	if (IsSomethingSelected)
	return;

I think it should be:

-        if (IsSomethingSelected)
+        if (!IsSomethingSelected)

Any comments? So I can commit the fix on branch v0.39.1-dev

Edit: Wrong file link, updated it

[VitoBarra]

yes that definitely is a correct fix, but I’m testing it and even so it seems not to work.
I’m trying to find out what’s going on.

I think it is just a visualization problem now

[AOx0]

Hm, it does work fine for me with 87e367c. By fine I mean now wires do connect to same Pin types, both out and in

[VitoBarra]

yep, that works for me too. I was referring to the fact that if you change the wire type and then try to edit again it will show as it is still simple, I don't know if it was the case also earlier tho

[AOx0]

Oh, I see it now. I'm looking into it.

Edit. If you get a working branch make a PR targeting branch v0.39.1-dev