refactor: shrink fallback, merge email benchmarks, dedupe bool prefs - #771
Open
qasimsethi-code wants to merge 1 commit into
Open
refactor: shrink fallback, merge email benchmarks, dedupe bool prefs#771qasimsethi-code wants to merge 1 commit into
qasimsethi-code wants to merge 1 commit into
Conversation
- condense getFallbackInstructions from a 31-line SKILL.md mirror to the paragraph form the Hermes port already proved sufficient - merge claude-email.js + model-email.js into email-rate.js with a provider table; hand-rolled .env parsing -> util.parseEnv (Node >=20.12) - fold getQuietStartup/getHideStatus into one boolPref resolver, behavior and exports unchanged - fix Hermes example filter to require a quoted value, mirroring the JS guard: prose bullets starting with a mode word survive mode filtering Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
Friendly triage note, no rush at all: this is primarily a bugfix for #772 (the Hermes port silently drops prose bullets that start with a mode word), with the audit cleanups riding along. Since first-contribution CI needs maintainer approval here, I ran the identical test workflow on a temporary mirror — passed clean on ubuntu-latest / Node 22 / Python 3.12 (84/84 across all four suites). Happy to split the bugfix into its own minimal PR if that's easier to take. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran /ponytail-audit on the repo and applied the surviving findings. Net −41 lines, no behavior changes except one deliberate fix (last bullet).
getFallbackInstructions: condensed the 31-line hand-maintained SKILL.md mirror to paragraph form — the same shape_fallback_instructionsin the Hermes port already uses. It only runs whenSKILL.md(shipped in the same package) is unreadable; the full mirror was sync debt with no payoff.benchmarks/email-rate.jsreplacesclaude-email.js+model-email.js: same harness loop existed twice differing only in thecall()and env names. One file, two-entry provider table. Env contract:PROVIDER=claude|openai,N,MODELS(wasCE_*/ME_*)..envparsing: hand-rolled kv parser (duplicated in both email scripts) →util.parseEnv(Node ≥20.12).boolPref(envVar, configKey)in ponytail-config folds the twingetQuietStartup/getHideStatusresolvers; exports and env→config→default semantics unchanged._filter_skill_body_for_mode's example regex was missing the"quote guard the JS version added deliberately — a prose bullet starting with a mode word was silently dropped in every other mode. Now mirrorshooks/ponytail-instructions.js.Audit also flagged the root
plugin.jsonas unreferenced — wrong, it's the Grok adapter manifest (tests/grok-plugin.test.jscaught it); left untouched.Tests: root 83/84 (the one failure is
csv: correct pandas one-liner passes, environmental — no pandas on this machine, fails on a pristine checkout too), hermes 8/8, pi-extension 23/23, ponytail-mcp 3/3.🤖 Generated with Claude Code
Fixes #772.