-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create simple box device for memory input/output #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 92.32% 92.47% +0.14%
==========================================
Files 44 45 +1
Lines 1186 1222 +36
==========================================
+ Hits 1095 1130 +35
- Misses 91 92 +1
|
For context my use case is for creating devices/etc to be used in system tests in Artemis (ophyd-bluesky). They just need to be set and read from a network and do not need to talk to each other. I'm sure I'll see soon enough if I end up making a lot of these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a really nice helper, I reckon it's a good addition to the framework.
It may be useful to add the option of outputting select keys at update time, thoughts?
I considered outputting keys at update time, what do you think the best solution is out of these?
Or indeed, do you have any other ideas? |
A partial |
524f849
to
6bb1c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to include a system test to cover the ComponentConfig
Co-authored-by: Garry O'Donnell <garry.o'donnell@diamond.ac.uk>
6bb1c5e
to
448ce61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR just illustrates an idea that came up in discussion with @abbiemery, not necessarily to be merged.
The envisioned use of this class is where you wish to simulate a network interface but the internal hardware logic is either not needed or very simple. A custom adapter can be made for the network interface and can simply read and write to an IoBox. I wondered if a lot of people would write devices like this and if it would make sense for tickit to provide a simple helper device.
Any thoughts welcome.