Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move container CI into a separate workflow #40

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Move container CI into a separate workflow #40

merged 6 commits into from
Nov 10, 2021

Conversation

collang
Copy link
Collaborator

@collang collang commented Nov 9, 2021

  • Container CI moved to separate workflow
  • Container CI now triggers on push to master

@collang collang requested a review from garryod November 9, 2021 11:10
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #40 (fd5fece) into master (320d1f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files          46       46           
  Lines        1424     1424           
=======================================
  Hits         1377     1377           
  Misses         47       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320d1f0...fd5fece. Read the comment docs.

Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How do we control when the container workflow is run?
  2. Should we add a badge for container build since it's now a separate workflow?

@collang
Copy link
Collaborator Author

collang commented Nov 9, 2021

The container workflow will trigger on a push to master, which I think covers:

  • Changes pushed directly to master
  • PR merged with master
    I suppose we could add a badge to show that the containers are working? I don't know whether other repos are set up this way.

@collang collang force-pushed the ci_update branch 3 times, most recently from 288e87e to 0d876ef Compare November 9, 2021 14:26
@collang collang requested a review from garryod November 9, 2021 16:09
@collang collang merged commit 86fd829 into master Nov 10, 2021
@collang collang deleted the ci_update branch November 10, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants