Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

109 fix pytest warnings #112

Merged
merged 7 commits into from
Mar 9, 2023
Merged

109 fix pytest warnings #112

merged 7 commits into from
Mar 9, 2023

Conversation

abbiemery
Copy link
Collaborator

Fixes #109

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #112 (ef1df55) into master (e4d50c8) will decrease coverage by 1.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   93.87%   92.19%   -1.68%     
==========================================
  Files          44       44              
  Lines        1127     1128       +1     
==========================================
- Hits         1058     1040      -18     
- Misses         69       88      +19     
Impacted Files Coverage Δ
src/tickit/utils/configuration/loading.py 100.00% <100.00%> (ø)
src/tickit/adapters/httpadapter.py 51.42% <0.00%> (-48.58%) ⬇️
src/tickit/core/adapter.py 85.71% <0.00%> (-7.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbiemery abbiemery merged commit 628ae9d into master Mar 9, 2023
@abbiemery abbiemery deleted the 109_fix_pytest_warnings branch March 9, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pytest warnings
2 participants