Skip to content

Conversation

@adedamola-sode
Copy link
Collaborator

@adedamola-sode adedamola-sode commented Nov 6, 2025

.yaml.

The generation of screens and schema generation have been modified to handle a list of dictionaries for when multiple screens are needed from one Guicomponent.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.58%. Comparing base (4df7e23) to head (ab79e29).

Files with missing lines Patch % Lines
src/techui_builder/generate.py 81.81% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   81.73%   81.58%   -0.16%     
==========================================
  Files           7        7              
  Lines         564      581      +17     
==========================================
+ Hits          461      474      +13     
- Misses        103      107       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adedamola-sode adedamola-sode force-pushed the screens-with-multiple-components branch from 7f32583 to 5c58fc0 Compare November 10, 2025 08:23
@adedamola-sode adedamola-sode changed the title extended ability for generate to handle dict_of_dicts in the ibek_map… extended ability for generate to handle dict_of_dicts in the techui_support… Nov 10, 2025
@adedamola-sode adedamola-sode marked this pull request as ready for review November 10, 2025 09:23
@adedamola-sode adedamola-sode changed the title extended ability for generate to handle dict_of_dicts in the techui_support… extended ability for generate to handle list_of_dicts in the techui_support… Nov 10, 2025
@adedamola-sode adedamola-sode force-pushed the screens-with-multiple-components branch 2 times, most recently from e33048b to 83c699b Compare November 11, 2025 10:44
@OCopping OCopping force-pushed the screens-with-multiple-components branch from d76607a to 127cab1 Compare November 11, 2025 13:51
@adedamola-sode adedamola-sode force-pushed the screens-with-multiple-components branch from 127cab1 to 8284b72 Compare November 12, 2025 08:39
Copy link
Collaborator

@OCopping OCopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add an example to the example techui.yaml, that uses this new logic?

@OCopping
Copy link
Collaborator

Coverage is also lower, so can more tests be written to keep this to at least the same level as main? (~56%)

@adedamola-sode
Copy link
Collaborator Author

It'll need a change in the techui_support.yaml file, i'd suggest local changes instead so we leave the techui_support alone because it's supposed to be the repo for screens and pointer to screens

@adedamola-sode
Copy link
Collaborator Author

For example: copy
gda:

  • file: "pmac/motor_embed.bob"
    prefix: "$(P)"
    type: "embedded"
  • file: "pmac/motor_embed.bob"
    prefix: "$(P)"
    type: "embedded"
  • file: "pmac/motor_embed.bob"
    prefix: "$(P)"
    type: "embedded"
  • file: "pmac/motor_embed.bob"
    prefix: "$(P)"
    type: "embedded"

into the techui_support.yaml.

This into the IOC .yaml :

  • type: gda
    P: BL01T-DI-MOTOR-01

and this into techui.yaml:
gda:
prefix: BL01T-DI-MOTOR-01

Sorry this is all long winded, I could add this to the support module, but should we?

@adedamola-sode
Copy link
Collaborator Author

Coverage is also lower, so can more tests be written to keep this to at least the same level as main? (~56%)

The tests are in the other test PR

@adedamola-sode adedamola-sode force-pushed the screens-with-multiple-components branch from c43c0b7 to a2d4abc Compare November 14, 2025 14:28
@OCopping OCopping force-pushed the screens-with-multiple-components branch from ea894f4 to a548a48 Compare November 14, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants