-
Notifications
You must be signed in to change notification settings - Fork 1
extended ability for generate to handle list_of_dicts in the techui_support… #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 81.73% 81.58% -0.16%
==========================================
Files 7 7
Lines 564 581 +17
==========================================
+ Hits 461 474 +13
- Misses 103 107 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7f32583 to
5c58fc0
Compare
e33048b to
83c699b
Compare
d76607a to
127cab1
Compare
127cab1 to
8284b72
Compare
OCopping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add an example to the example techui.yaml, that uses this new logic?
|
Coverage is also lower, so can more tests be written to keep this to at least the same level as main? (~56%) |
|
It'll need a change in the techui_support.yaml file, i'd suggest local changes instead so we leave the techui_support alone because it's supposed to be the repo for screens and pointer to screens |
|
For example: copy
into the techui_support.yaml. This into the IOC .yaml :
and this into techui.yaml: Sorry this is all long winded, I could add this to the support module, but should we? |
The tests are in the other test PR |
c43c0b7 to
a2d4abc
Compare
ea894f4 to
a548a48
Compare
.yaml.
The generation of screens and schema generation have been modified to handle a list of dictionaries for when multiple screens are needed from one Guicomponent.