Open
Conversation
Contributor
LuisFSegalla
left a comment
LuisFSegalla
left a comment
There was a problem hiding this comment.
The changes seem good to me. I only suggest waiting to merge this until the dodal PR has been approved and merged, otherwise I think we can have some conflicts as we're tracking the latest release of dodal and it doesn't have the changes yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the documentation in https://diamondlightsource.github.io/blueapi/main/how-to/integrate-with-numtracker.html Section Updating BlueAPI and Dodal, after updating P51 to use Device Manager & Numtracker, data sessions decorator can be safely removed.
Corresponding PR in dodal: DiamondLightSource/dodal#1930