Add units to UnitConv classes. #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Should we add a get_units(field) method or are we content with the get_unitconv(field).eng/phys_units syntax? |
Collaborator
Author
|
@willrogers I think this should be good to merge now. |
willrogers
reviewed
Oct 31, 2018
utils/load_unitconv.m
Outdated
| sext_families = findmemberof('SEXT'); | ||
|
|
||
| % Unit conversions for lattice fields | ||
| fprintf(f_units, '%d,%s,poly,%d,%s,%s\n', 0, 'energy', 0, 'Mev', 'Mev'); |
Collaborator
There was a problem hiding this comment.
Should be MeV and GeV (GeV being whichever is the smaller number)
Collaborator
Author
There was a problem hiding this comment.
Good catch I will correct the physics units to Gev.
utils/load_unitconv.m
Outdated
| end | ||
| id = write_linear_data(data.field(2) / data.current(2), 0); | ||
| fprintf(f_units, '%d,%s,poly,%d\n', renamedIndexes(hcor_index), 'x_kick', id); | ||
| fprintf(f_units, '%d,%s,poly,%d,%s,%s\n', renamedIndexes(hcor_index), 'x_kick', id, 'rads^-2', 'A'); |
Collaborator
There was a problem hiding this comment.
Not sure where rads^-2 came from. The value is in radians, but for simplicity we are treating radians as dimensionless: https://en.wikipedia.org/wiki/Radian#Dimensional_analysis
Collaborator
Author
There was a problem hiding this comment.
In that case, should it be 'rads', 'A' or '', 'A'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge