Skip to content

Exceptions Updates #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willrogers merged 1 commit into from
Oct 4, 2018
Merged

Exceptions Updates #97

willrogers merged 1 commit into from
Oct 4, 2018

Conversation

@T-Nicholls
Copy link
Collaborator

@T-Nicholls T-Nicholls commented Oct 4, 2018

Changes made:

  • Updates to almost every single exception message.
  • Changed DeviceException to DataSourceException.
  • Removed LatticeException.
  • Added ControlSystemException.
  • Amended to the old exceptions raised tests.
  • Added new exception tests.
  • Corrected outdated descriptions of exceptions in the comments.
  • Fixed some spacing.

@T-Nicholls T-Nicholls mentioned this pull request Oct 4, 2018
Closed
@coveralls
Copy link

coveralls commented Oct 4, 2018

Coverage Status

Coverage increased (+0.06%) to 99.483% when pulling a0b3082 on T-Nicholls:nullUC into 875cb32 on dls-controls:master.

@T-Nicholls T-Nicholls mentioned this pull request Oct 4, 2018
Merged
@willrogers
Copy link
Collaborator

willrogers commented Oct 4, 2018

There are a lot of changes here but they're not particularly controversial, so I'm more or less going to assume that they're ok and merge.

@willrogers willrogers merged commit dbc01c8 into DiamondLightSource:master Oct 4, 2018
@T-Nicholls T-Nicholls deleted the nullUC branch October 4, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@T-Nicholls @coveralls @willrogers