Add NullUnitConv class #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willrogers
reviewed
Oct 2, 2018
pytac/units.py
Outdated
| """Doesn't convert between engineering and physics units. | ||
|
|
||
| Maintains the same syntax as the other UnitConv classes for | ||
| compatability, but does not perform any conversion. |
willrogers
reviewed
Oct 2, 2018
pytac/units.py
Outdated
|
|
||
|
|
||
| class NullUnitConv(UnitConv): | ||
| """Returns inupt value without performing any conversions. |
willrogers
reviewed
Oct 2, 2018
pytac/units.py
Outdated
| """Doesn't convert between physics and engineering units. | ||
|
|
||
| Maintains the same syntax as the other UnitConv classes for | ||
| compatability, but does not perform any conversion. |
Collaborator
|
There are a couple of typos but otherwise this is fine. |
Collaborator
Author
|
Fixed the typos, this should be ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.