Pyepics, Caproto and joint testing #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
These tests are failing because they reference some of the Cothread changes made on #94, once that pull request has been merged these tests will pass again. |
Contributor
|
Closed accidentally when changing base branch name from master to main. Please explain why we may still want to do this, and if so please make a new PR to merge to main. Thanks. |
Collaborator
Author
|
No clue why this was still open after so long! I don't think it needs to be reimplemented, it was intended as a learning experience and proof of concept more than anything. If we do want to use a control system other than Cothread in future, then we can revisit this then, but no point in doing the extra work now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.