Skip to content

Ensure that device.is_enabled() returns a boolean. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willrogers merged 1 commit into from
Nov 20, 2017
Merged

Ensure that device.is_enabled() returns a boolean. #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytac/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def is_enabled(self):
Returns:
boolean: whether the device is enabled
"""
return self._enabled
return bool(self._enabled)

def put_value(self, value):
"""Set the device value.
Expand Down
5 changes: 5 additions & 0 deletions test/test_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ def test_device_is_disabled_if_False_enabler():
assert not device.is_enabled()


def test_device_is_enabled_returns_bool_value():
device = create_device(enabled=mock.MagicMock())
assert device.is_enabled() is True


def test_PvEnabler():
mock_cs = mock.MagicMock()
mock_cs.get.return_value = '40'
Expand Down