Investigations #105
Merged
Investigations #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@T-Nicholls I'm happy to merge this one now, any comments? I don't know why Travis hasn't reported back but the build passed. |
eng_to_phys() and phys_to_eng()
Collaborator
Author
|
@aawdls @T-Nicholls this branch is ready to merge and when it is merged I plan to release 0.3.0. Any final comments? |
T-Nicholls
reviewed
Jul 9, 2019
Collaborator
T-Nicholls
left a comment
T-Nicholls
left a comment
There was a problem hiding this comment.
Just a few docstring comments, caused by the multiple rearranges.
I am happy with this. Could Andy please check that the virtual accelerator will now start without errors on this branch, as I cannot run ATIP at home.
willrogers
force-pushed
the
investigations
branch
from
c677379 to
e711e67
Compare
Contributor
|
I'm getting a UnitsException |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@T-Nicholls implemented a couple of the suggestions on this branch. I'll do the id/name one next.