Three modifications: Handling of overloaded pixels, signed data arrays and image number offsets#25
Open
CV-GPhL wants to merge 11 commits intoDiamondLightSource:masterfrom
Open
Three modifications: Handling of overloaded pixels, signed data arrays and image number offsets#25CV-GPhL wants to merge 11 commits intoDiamondLightSource:masterfrom
CV-GPhL wants to merge 11 commits intoDiamondLightSource:masterfrom
Conversation
to convert to (signed) int and apply pixel mask. The environment variable DURIN_RESET_UNMASKED_PIXEL can now be used to set non-masked saturated pixels in order to process them correctly with e.g. XDS.
Catching up 20240223
Update plugin.c to write compilation time if available/set
understood on the XDS side) and the image ordinal (as stored in the HDF data). The 2D data arrays are not necessarily at image_nr_low=1 ;-)
loading/using the normal bitshuffle source from https://github.com/kiyo-masui/bitshuffle (see Makefile).
DATATYPE H5T_STRING {
STRSIZE 14;
STRPAD H5T_STR_NULLTERM;
CSET H5T_CSET_ASCII;
CTYPE H5T_C_S1;
}
and
DATATYPE H5T_STRING {
STRSIZE H5T_VARIABLE;
STRPAD H5T_STR_NULLTERM;
CSET H5T_CSET_UTF8;
CTYPE H5T_C_S1;
}
|
I presume given the updated commits that you'd still like this merged in? |
Author
Yes - if possible (and deemed sensible/useful/correct). I'd like to use a version of the plugin within autoPROC as close to the "official" source as possible. |
Ensure the buffer is null terminated after allocation - otherwise correct results from strcmp below is undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are three changes/modifications:
Any comments appreciated ;-)