Fix Mypy Errors Caused by Pillow #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of pillow includes type hints, which seems to have caused mypy to pay more attention to it and thrown up a couple of issues. Nothing significant but blocks CI on other PRs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 91 91
Lines 3474 3474
=======================================
Hits 3256 3256
Misses 218 218 ☔ View full report in Codecov by Sentry. |
callumforrester
requested review from
DominicOram,
DiamondJoseph,
dperl-dls and
olliesilvester
2 tasks
DiamondJoseph
requested changes
Apr 3, 2024
DiamondJoseph
approved these changes
Apr 3, 2024
callumforrester
force-pushed
the
fix-mypy-errors
branch
from
4ad30f4
to
a600e3d
Compare
callumforrester
force-pushed
the
fix-mypy-errors
branch
from
a600e3d
to
7a32c20
Compare
callumforrester
force-pushed
the
fix-mypy-errors
branch
from
7a32c20
to
bce7774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of pillow (10.3.0) includes type hints, which seems to have
caused mypy to pay more attention to it and thrown up a couple of
issues. Nothing significant but blocks CI on other PRs.
Pillow PR that added type hints: python-pillow/Pillow@b6c755d
Instructions to reviewer on how to test:
Checks for reviewer