Skip to content

1810 yaml configuration generation#1811

Draft
Relm-Arrowny wants to merge 20 commits intomainfrom
1810-yaml-configuration-generation
Draft

1810 yaml configuration generation#1811
Relm-Arrowny wants to merge 20 commits intomainfrom
1810-yaml-configuration-generation

Conversation

@Relm-Arrowny
Copy link
Contributor

Fixes #1810

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Jan 8, 2026 that may be closed by this pull request
17 tasks
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.09%. Comparing base (e0d5a17) to head (50f9a62).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dodal/common/beamlines/config_generator.py 90.32% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   99.14%   99.09%   -0.05%     
==========================================
  Files         288      290       +2     
  Lines       10937    11012      +75     
==========================================
+ Hits        10843    10912      +69     
- Misses         94      100       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Relm-Arrowny Relm-Arrowny mentioned this pull request Jan 16, 2026
17 tasks
@tpoliaw
Copy link
Contributor

tpoliaw commented Jan 19, 2026

I've not looked too closely at the code in this PR yet as it's still a draft but I think it would be worth discussing the approach and what the final config files should look like before working on the implementation too much. I have put more comments on the issue thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YAML Configuration Generation

4 participants