Draft
Conversation
17 tasks
…ndLightSource/dodal into 1810-yaml-configuration-generation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
- Coverage 99.14% 99.09% -0.05%
==========================================
Files 288 290 +2
Lines 10937 11012 +75
==========================================
+ Hits 10843 10912 +69
- Misses 94 100 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ndLightSource/dodal into 1810-yaml-configuration-generation
17 tasks
Contributor
|
I've not looked too closely at the code in this PR yet as it's still a draft but I think it would be worth discussing the approach and what the final config files should look like before working on the implementation too much. I have put more comments on the issue thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1810
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}