Merged
Conversation
Contributor
|
Does this get served at |
Contributor
|
This will not get served in the main application. The image only exists in the The only human-readable web endpoint Coniql really exposes is /ws, and that's only when we turn on I can see the appeal in including it in the actual application. I can also see that there's no real point in doing so, at least at present, as there will be no-one to view it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the the favicon and logo based on the updated image provided in #54. As far as I can tell, the favicon already appears on the documentation webpage (see https://diamondlightsource.github.io/coniql/main/index.html), so nothing more to do there.