Merged
Conversation
AlexanderWells-diamond
requested changes
Jan 8, 2024
Contributor
AlexanderWells-diamond
left a comment
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
Please raise the issue now, so that you can add a comment to all relevant places quoting the issue number.
Collaborator
Author
|
Raised issue #101 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 10 10
Lines 856 856
=======================================
Hits 806 806
Misses 50 50 ☔ View full report in Codecov by Sentry. |
AlexanderWells-diamond
approved these changes
Jan 9, 2024
Contributor
AlexanderWells-diamond
left a comment
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 was causing various github actions to fail, due to deprecation of distutils. I have pinned python versions to 3.11 where necessary, and also removed the pytest config that treats warnings as errors. I will also open an issue for this issues to be handled in the longer term.