fix: Pass authn context into TiledWriter context#1280
Merged
DiamondJoseph merged 7 commits intomainfrom Dec 9, 2025
Merged
Conversation
DiamondJoseph
force-pushed
the
authn-context
branch
from
d92af26 to
0f5dbc9
Compare
DiamondJoseph
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 94.93% 94.74% -0.19%
==========================================
Files 42 42
Lines 2724 2741 +17
==========================================
+ Hits 2586 2597 +11
- Misses 138 144 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
force-pushed
the
authn-context
branch
from
b254d68 to
cc23961
Compare
DiamondJoseph
force-pushed
the
authn-context
branch
from
cc23961 to
d3d27ce
Compare
DiamondJoseph
force-pushed
the
internal-debug
branch
2 times, most recently
from
1f5cb3a to
6686848
Compare
DiamondJoseph
force-pushed
the
authn-context
branch
from
d3d27ce to
29a8120
Compare
DiamondJoseph
force-pushed
the
authn-context
branch
from
29a8120 to
493ac83
Compare
DiamondJoseph
force-pushed
the
authn-context
branch
from
2422686 to
9230099
Compare
DiamondJoseph
force-pushed
the
authn-context
branch
from
3831456 to
fedd16a
Compare
tpoliaw
approved these changes
Dec 9, 2025
Contributor
tpoliaw
left a comment
tpoliaw
left a comment
There was a problem hiding this comment.
begin_task in the interface feels like the wrong place for this but given numtracker is doing the same thing in the same place it'll probably work for now.
Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ACQP-474, ACQP-475 by passing authentication information into the TiledWriter, to allow writing to a Tiled that uses proxy OIDC authentication.
Also refactors handling of #1201/#1202
Introduces #1296 which can be revisited once the Tiled authz changes have gone in.