Skip to content

Fix techdocs publishing by passing secrets#232

Merged
garryod merged 1 commit intomainfrom
fix-techdocs-secrets
Jan 9, 2025
Merged

Fix techdocs publishing by passing secrets#232
garryod merged 1 commit intomainfrom
fix-techdocs-secrets

Conversation

@garryod
Copy link
Contributor

@garryod garryod commented Jan 9, 2025

I missed the fact that by making _techdocs_publish a re-usable workflow secrets would not be passed automatically - and testing was skipped on the PR because the step is only run on main. This PR fixes this by passing the secrets to the re-usable workflow explicitly

@garryod garryod added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Jan 9, 2025
@garryod garryod requested a review from GDYendell January 9, 2025 13:48
@garryod garryod self-assigned this Jan 9, 2025
@garryod garryod marked this pull request as ready for review January 9, 2025 13:50
@garryod garryod merged commit 7da1b33 into main Jan 9, 2025
33 checks passed
@GDYendell GDYendell deleted the fix-techdocs-secrets branch January 9, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants