Skip to content

ci: add commitlint to enforce conventional commits#231

Closed
garryod wants to merge 1 commit intorefactor-cifrom
lint-commits
Closed

ci: add commitlint to enforce conventional commits#231
garryod wants to merge 1 commit intorefactor-cifrom
lint-commits

Conversation

@garryod
Copy link
Contributor

@garryod garryod commented Jan 8, 2025

Requires #230

Adds commitlint to CI in order to ensure commits messages conform to conventional commits. This is necessary prerequisite for using release please

@garryod garryod added the github_actions Pull requests that update GitHub Actions code label Jan 8, 2025
@garryod garryod requested a review from GDYendell January 8, 2025 10:58
@garryod garryod self-assigned this Jan 8, 2025
@garryod garryod force-pushed the lint-commits branch 2 times, most recently from 46dbd7a to b43c2f4 Compare January 8, 2025 11:01
@garryod garryod changed the title ci: Add commitlint to CI ci: add commitlint to CI Jan 8, 2025
@garryod garryod changed the title ci: add commitlint to CI ci: add commitlint to enforce conventional commits Jan 8, 2025
@GDYendell
Copy link
Collaborator

GDYendell commented Jan 8, 2025 •
edited
Loading

If you set refactor-ci as the target branch for this PR, the diff will be what you expect and easy to review, and it will be automatically updated to target main when the other PR is merged (and the source branch deleted).

@garryod
Copy link
Contributor Author

garryod commented Jan 8, 2025

If you set refactor-ci as the target branch for this PR, the diff will be what you expect and easy to review, and it will be automatically updated to target main when the other PR is merged (and the source branch deleted).

Oh neat, didn't realise that

@garryod garryod changed the base branch from main to refactor-ci January 8, 2025 13:54
@garryod garryod force-pushed the refactor-ci branch 18 times, most recently from b3fb476 to 6ba22b3 Compare January 9, 2025 10:35
@garryod garryod marked this pull request as ready for review January 9, 2025 13:37
GDYendell
GDYendell approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to delete the refactor-ci branch to make this PR target main (or change it manually).

@garryod garryod deleted the branch refactor-ci January 9, 2025 15:00
@garryod garryod closed this Jan 9, 2025
@garryod garryod deleted the lint-commits branch January 9, 2025 15:00
@garryod garryod restored the lint-commits branch January 9, 2025 15:01
@garryod
Copy link
Contributor Author

garryod commented Jan 9, 2025

You'll need to delete the refactor-ci branch to make this PR target main (or change it manually).

Deleted the branch and it just closed the PR 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GDYendell GDYendell GDYendell approved these changes

Assignees

@garryod garryod

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garryod @GDYendell