Conversation
tpoliaw
force-pushed
the
issuer_env
branch
2 times, most recently
from
d50ac6d to
eb9c966
Compare
Contributor
|
We should probably use the OIDC discovery endpoint to get these, see: https://openid.net/specs/openid-connect-discovery-1_0.html |
Collaborator
Author
|
From the OPA docs here it looks like we should be setting ISSUER but not JWKS_ENDPOINT |
tpoliaw
force-pushed
the
issuer_env
branch
3 times, most recently
from
017d249 to
329a0c2
Compare
garryod
suggested changes
Nov 14, 2024
garryod
previously approved these changes
Nov 14, 2024
Collaborator
Author
|
Sorry, found a docs change I missed in the final read through |
garryod
approved these changes
Nov 14, 2024
Contributor
No worries, much preferred to finding it six months from now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only remembered we'd added this to the token validation after the other PR was merged. Not sure what the issuer value should be so I opted for the value used in the docs/examples.