Skip to content

Add testing of data fetching#2

Merged
garryod merged 2 commits intomainfrom
snapshot-tests
Dec 7, 2023
Merged

Add testing of data fetching#2
garryod merged 2 commits intomainfrom
snapshot-tests

Conversation

@garryod
Copy link
Contributor

@garryod garryod commented Dec 4, 2023

Would like to hear your thoughts on these, not 100% sure how I feel, but they're very quick to write

Didn't like the snapshot tests for this, went with regular old unit tests

@garryod garryod requested a review from DiamondJoseph December 4, 2023 14:54
@garryod garryod self-assigned this Dec 4, 2023
@garryod garryod force-pushed the snapshot-tests branch 2 times, most recently from d67392c to bf1db63 Compare December 4, 2023 16:53
@garryod garryod changed the title Add snapshot testing of data fetching Add testing of data fetching Dec 4, 2023
@DiamondJoseph
Copy link

Might have to talk me through it
If Person is on Proposal and Session is in Proposal means that Person is on Session it seems sensible.
But I don't know how valid that presumption is: can a Person be on a Proposal but not on every Session?

I can probably sneak some time away from the americans tomorrow or Wednesday

@garryod
Copy link
Contributor Author

garryod commented Dec 5, 2023

Might have to talk me through it If Person is on Proposal and Session is in Proposal means that Person is on Session it seems sensible. But I don't know how valid that presumption is: can a Person be on a Proposal but not on every Session?

I can probably sneak some time away from the americans tomorrow or Wednesday

This is how things work in UAS and with file system permissions, so I reckon it's a good assumption for now

@DiamondJoseph
Copy link

I just don't want to be making any assumption in AuthZ. Underlying database should be explicit with what it wants.

Are you at any of the americans meetings today or tomorrow?

@garryod garryod merged commit fb9c711 into main Dec 7, 2023
@garryod garryod deleted the snapshot-tests branch December 15, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants