Support keycloak token authentication#187
Merged
tpoliaw merged 1 commit intoDiamondLightSource:mainfrom Oct 31, 2024
Merged
Conversation
garryod
suggested changes
Oct 31, 2024
Contributor
There was a problem hiding this comment.
I think I would prefer if we were to have a deployment level switch (e.g. env var) which selected between KeyCloak and CAS, since they both need their respective env vars anyway (USERINFO_ENDPOINT or JWKS_ENDPOINT)
Edit: Haven given it further consideration I think we want an env var which can be overridden by an input, such that the central deployments behaviour can be configured by it's caller
Contributor
|
Discussed in person, decided we should only support KeyCloak JWTs as CAS isn't being used by anyone and is due for deprecation |
tpoliaw
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.