Add static data support to bundler#179
Merged
garryod merged 12 commits intoDiamondLightSource:mainfrom Oct 10, 2024
Merged
Conversation
tpoliaw
force-pushed
the
static_bundle_data
branch
from
8d95079 to
08b1d8e
Compare
Collaborator
Author
|
I also have no idea which beamlines belong to which group so the sample admin.json is very incomplete |
tpoliaw
force-pushed
the
static_bundle_data
branch
from
08b1d8e to
c63aa93
Compare
tpoliaw
force-pushed
the
static_bundle_data
branch
from
c63aa93 to
1bda715
Compare
garryod
reviewed
Oct 3, 2024
Contributor
garryod
left a comment
garryod
left a comment
There was a problem hiding this comment.
Looks reasonable, think I'd rather pass a glob in than have it select every json in a directory
* Unbox CLI args * Include static data in revision info * Fail on fs errors when reading static data
garryod
suggested changes
Oct 3, 2024
Contributor
garryod
left a comment
garryod
left a comment
There was a problem hiding this comment.
Looking good, just a couple little bits
garryod
added
enhancement
These are the most common beamlines for visits of users with the respective admin permissions.
They are used as strings so storing them as strings makes more sense. It also makes the tracing sane again as debug format for patterns is incredibly verbose. Strings are still validated by the CLI.
garryod
reviewed
Oct 9, 2024
Collaborator
Author
|
The chart lints are failing, presumably because adding the static data counts as a change. Should the data be added in its own PR? |
Contributor
Yeah, probably add it as it's own thing - or as part of #186 |
This can be added at a later time and is not required for static data support.
garryod
reviewed
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for adding static file support to bundler service. Any files named
*.jsonin the optional static_data_directory will be included in the generated bundle under a name matching the file name.eg, using the new
staticdirectory, the bundle structure is nowStatic directory location subject to bikeshedding.