Fix OPA deployment checksum/config annotation#118
Merged
Conversation
garryod
approved these changes
May 28, 2024
MattPrit
force-pushed
the
fix-opa-config-checksum
branch
from
c4ab530 to
68f1f66
Compare
garryod
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 134421a,
.Values.configincharts/opa/templates/deployment.yamlhas evaluated tonull. This causes thechecksum/configannotation on the OPA deployment to not work correctly. Ifvalues.yamlare changed such that the outputcharts/opa/templates/opa-config.yamlis changed butcharts/opa/templates/deployment.yamlis not directly updated,helm upgradewill not cause the deployment to be updated, and OPA will not be configured as desired. An example would be adding an extra policy bundle.This change should fix this issue by using the output value of
charts/opa/templates/opa-config.yamlin the checksum.