Add @atlas/blueapi and @atlas/blueapi-query packages#17
Open
douglaswinter wants to merge 6 commits intomainfrom
Open
Add @atlas/blueapi and @atlas/blueapi-query packages#17douglaswinter wants to merge 6 commits intomainfrom
douglaswinter wants to merge 6 commits intomainfrom
Conversation
douglaswinter
requested review from
EmsArnold,
VictoriaBeilsten-Edmands and
noemifrisina
and removed request for
EmsArnold,
VictoriaBeilsten-Edmands and
noemifrisina
Just linting for ViSR - still need to sort out consistent linting for all apps and packages.
To remove the expectation of prebuilt dist/ folders, we can use composite projects and references. https://www.typescriptlang.org/docs/handbook/project-references.html In this setup: 1) each internal TS package declares itself as composite: "compilerOptions": { "composite": true } 2) each dependent package lists its dependencies as references: "references": [{ "path" : "../dependency" }] 3) each package is built with tsc -b
noEmit should not be in root config; only app configs should declare it
douglaswinter
force-pushed
the
dw/blueapi_package
branch
from
e11e3c7 to
4d8f194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing two very light packages.
@atlas/blueapi: axios blueapi queries. Can be used as is, or through
@atlas/blueapi-query: tanstack react query wrappers for the above, exposing hooks such as usePlans(), etc.