Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views module: make variables lowercase (convention) #382

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

willfurnass
Copy link
Collaborator

XDATA, YDATA and EIGENVALUES have been made lowercase as that's the convention for non-constants.

@willfurnass
Copy link
Collaborator Author

CI failing as this needs to be rebased on #380

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3cd01ed). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #382   +/-   ##
=========================================
  Coverage          ?   11.42%           
=========================================
  Files             ?        9           
  Lines             ?     5787           
  Branches          ?     1582           
=========================================
  Hits              ?      661           
  Misses            ?     5100           
  Partials          ?       26
Impacted Files Coverage Δ
mumot/views.py 8.82% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd01ed...66fd423. Read the comment docs.

@willfurnass willfurnass merged commit acea5b4 into DiODeProject:master Feb 16, 2020
@willfurnass willfurnass deleted the lowercase-vars branch February 16, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants