fix: summary calculation (formbricks#4500)

Dhruwang · Dec 19, 2024 · 74b770a · 74b770a
1 parent bd8724c
commit 74b770a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/lib/surveySummary.ts b/...)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/lib/surveySummary.ts
@@ -399,7 +399,7 @@ export const getQuestionSummary = async (
             value: label,
             count,
             percentage:
-              totalSelectionCount > 0 ? convertFloatTo2Decimal((count / totalSelectionCount) * 100) : 0,
+              totalResponseCount > 0 ? convertFloatTo2Decimal((count / totalResponseCount) * 100) : 0,
           });
         });
 
@@ -408,8 +408,8 @@ export const getQuestionSummary = async (
             value: getLocalizedValue(lastChoice.label, "default") || "Other",
             count: otherValues.length,
             percentage:
-              totalSelectionCount > 0
-                ? convertFloatTo2Decimal((otherValues.length / totalSelectionCount) * 100)
+              totalResponseCount > 0
+                ? convertFloatTo2Decimal((otherValues.length / totalResponseCount) * 100)
                 : 0,
             others: otherValues.slice(0, VALUES_LIMIT),
           });
@@ -452,8 +452,8 @@ export const getQuestionSummary = async (
             imageUrl: choice.imageUrl,
             count: choiceCountMap[choice.id],
             percentage:
-              totalSelectionCount > 0
-                ? convertFloatTo2Decimal((choiceCountMap[choice.id] / totalSelectionCount) * 100)
+              totalResponseCount > 0
+                ? convertFloatTo2Decimal((choiceCountMap[choice.id] / totalResponseCount) * 100)
                 : 0,
           });
         });

diff --git a/apps/web/modules/ee/contacts/page.tsx b/apps/web/modules/ee/contacts/page.tsx
@@ -84,7 +84,7 @@ export const ContactsPage = async ({
           contactAttributeKeys={contactAttributeKeys}
           isReadOnly={isReadOnly}
           initialContacts={initialContacts}
-          hasMore={initialContacts.length <= ITEMS_PER_PAGE}
+          hasMore={initialContacts.length >= ITEMS_PER_PAGE}
           refreshContacts={refreshContacts}
         />
       ) : (