-
Notifications
You must be signed in to change notification settings - Fork 64
Acceleration Structure Asset Conversion #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devshgraphicsprogramming
wants to merge
13
commits into
master
Choose a base branch
from
as-conv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs: - abstract away the staging cache insert/overwrite - check dependants of TLAS after creation of BLAS - insert the ASes into staging cache - collect the BLASes to use during TLAS builds
Finish getting build sizes for BLAS and TLAS Also ask for minimum allocation size constraint of the allocator
…cause that's supposed to be the "expensive" call Also prevent attempting to map the same memory multiple times (relevant in APIs that only allow a single mapping and we suballocate from same `IDeviceMemoryAllocation`) So now for a ReBAR upload to succeed, the memory allocation given out needs to be on the correct heap AND start off mapped (Asset Converter won't attempt to map by itself).
…Vulkan debug names on the created GPU objects right away. Push conversion requests to right after successful `assign` beause that makes more sense. Prep for host_image_copy support. Also make should-be-private structs private.
…Acceleration Structures to staging cache
…ssetConverter::reserve` TODO: make the staging cache refcounted with heterogenous (non-refcounted) lookup
…t, makes life a lot easier. add `IGPUTopLevelAccelerationStructure::getPendingBuildVer()` to detect if TLAS built yet also make sure the maxInstanceCount gets hashed properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
Description
Testing
TODO list: