-
Notifications
You must be signed in to change notification settings - Fork 64
Fixed some hlsl functions #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Przemog1
commented
Feb 27, 2025
•
edited by devshgraphicsprogramming
Loading
edited by devshgraphicsprogramming
- lp_norm partial spec is wrong/wont get called Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment) & Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- more requirements on lp_norm Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- dot should not constrain the dimensions or types
- cross_helper should allow non-float type vectorials
- make sure correct tgmath sqrt is being called throughout functions.hlsl Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- call nabla dot or dot_helper in lp_norm::__sum Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- nitpicks in lp_norm Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- beziers.hlsl should be using tgmath exp,exp2,log2 and friends Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment) also NBL_FLOAT64_LITERAL and stuffz
- loosen the requirements on reflect and refract also make them compile Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- use flipSign for sincos Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- use better concepts Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- condAbsOrMax Maths for HLSL BxDFs (template cmath, tgmath) #803 (comment)
- ideally applyChainRule should allow any Matricial, and call our templated mul (does it exist btw? or did it clash with HLSL mul )
@Przemog1 can you at least test example 62 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.