Skip to content

IShader, no more conversions, stage is now part of spec info. #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 67 commits into
base: master
Choose a base branch
from
Open

IShader, no more conversions, stage is now part of spec info. #839

wants to merge 67 commits into from

Conversation

devshgraphicsprogramming
Copy link
Member

@devshgraphicsprogramming devshgraphicsprogramming commented Feb 21, 2025 •
edited
Loading

Description

Remove unnecessary complexity of ICPUShader and IGPUShader.

Testing

All examples using shaders need to be tested.

TODO list:

  • require maintenance5 or graphics_pipeline_library
  • pass SPIR-V directly to pipeline creation without creating a VkShaderModule using maintenance5/graphics_pipeline_library pNext new API
  • set debug object name on created graphics pipeline libraries
  • use SPIR-V Tools & Opt to create a copy of the SPIR-V, remove entry points not used by spec info, then run DCE and capability stripping pass

This was referenced Mar 10, 2025
Open
Open
Merged
devshgraphicsprogramming
devshgraphicsprogramming commented Apr 16, 2025
View reviewed changes
src/nbl/asset/utils/ISPIRVDebloater.cpp Outdated
Comment on lines 85 to 86
std::cout << "Before strip capabilities: " << std::endl;
printCapabilities(spirv, spirvDwordCount);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the logger please

kevyuu added 12 commits April 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devshgraphicsprogramming @alichraghi