Skip to content

Fix an off-by-one bug with /janame #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
awoo-civ wants to merge 2 commits into from
Closed

Fix an off-by-one bug with /janame #10

awoo-civ wants to merge 2 commits into from

Conversation

@awoo-civ
Copy link
Collaborator

@awoo-civ awoo-civ commented Dec 28, 2016 •
edited
Loading

Steps to reproduce:

  1. Name a snitch with a 40-length string.
  2. The length displayed in /jalist is 40 (hover over the snitch entry)
  3. Name a snitch with a 41-length string.
  4. The length displayed in /jalist is 39.

/jainfo would work too obviously, as long as #9 is merged.

@awoo-civ awoo-civ changed the title Fix an off-by one bug with /janame Fix an off-by-one bug with /janame Dec 28, 2016
@ProgrammerDan ProgrammerDan mentioned this pull request Dec 31, 2016
Merged
@ProgrammerDan
Copy link

ProgrammerDan commented Dec 31, 2016

Superceded by #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awoo-civ @ProgrammerDan