Skip to content

Conversation

@RRRadicalEdward
Copy link
Collaborator

@RRRadicalEdward RRRadicalEdward commented Nov 7, 2025

The patch version upgrade is not allowed to bring breaking changes, but this rule doesn't work for an rc version. So we should pin the rc versions, to not allow cargo update to a new rc automatically.

Fixes #537.

@RRRadicalEdward
Copy link
Collaborator Author

Don't merge yet. Let me check that we don't have a similar issue in picky crates

@CBenoit
Copy link
Member

CBenoit commented Nov 7, 2025

Thank you! Also can you add a comment with a link to the issue, explaining why we pin all of that? Thanks!

@RRRadicalEdward
Copy link
Collaborator Author

Don't merge yet. Let me check that we don't have a similar issue in picky crates

Let's merge the picky Devolutions/picky-rs#430 first, release it, and update the picky version in this PR.

@CBenoit
Copy link
Member

CBenoit commented Nov 7, 2025

I’m currently merging the release PR, new version should be published soon!

@RRRadicalEdward RRRadicalEdward marked this pull request as ready for review November 7, 2025 15:02
@RRRadicalEdward RRRadicalEdward self-assigned this Nov 7, 2025
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBenoit CBenoit merged commit 6fc91fa into master Nov 7, 2025
63 checks passed
@CBenoit CBenoit deleted the pin-leftover-rc-crates branch November 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Dependency stability: Release candidate dependencies causing frequent downstream breakages

3 participants