-
Notifications
You must be signed in to change notification settings - Fork 23
fix: resolve clippy lints in win-api-wrappers for strict enforcement #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CBenoit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@copilot Run the following commands to verify your changes: cargo +nightly fmt --all
cargo clippy --workspace --tests -- -D warnings
cargo test --workspace |
Head branch was pushed to by a user without write access
... Verification complete:
All commands executed successfully. The only test failures are pre-existing network-related issues (DNS resolution for rust-lang.org) unrelated to these changes. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
fc19622 to
5c8d37c
Compare
Fix Clippy Linting Errors from PR #1561
PR #1561 enabled strict clippy enforcement (
-D warnings) in CI, exposing 14 warnings inwin-api-wrappersthat now break the build.Changes
Safety documentation
identity/account.rs,rpc.rsfs.rsCode quality improvements
netmgmt.rs: Suppressed unavoidablecast_ptr_alignmentwith documented justificationprocess.rs: Collapsed nested if using let-chain syntaxtoken.rs: Replacedas u8withu8::from()for lossless bool conversionutils.rs: Replacedrepeat().take()withrepeat_n()(3 instances)wts.rs: Replacedunwrap()withexpect()providing context (2 instances)Verification
All requested verification commands completed successfully:
cargo +nightly fmt --all- Applied formattingcargo clippy --workspace --tests -- -D warnings- Passedcargo test --workspace- Passed (pre-existing network test failures unrelated to changes)All changes preserve existing behavior while satisfying new clippy requirements.
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.