Skip to content

fix(pedm): don't panic on missing log_elevation function #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

thenextman
Copy link
Member

The unimplemented! macro causes us to panic here, which means elevation is not possible. This is counter productive to a minimum viable implementation (I do not know the current state of elevation logging).

@thenextman thenextman requested a review from a team May 6, 2025 18:06
Copy link

github-actions bot commented May 6, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@thenextman thenextman enabled auto-merge (squash) May 6, 2025 18:28
@thenextman thenextman merged commit f2dca24 into master May 6, 2025
41 checks passed
@thenextman thenextman deleted the pedm-log-elevation-not-implemented branch May 6, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants