[MacOS] Fix tabs #165
Merged
[MacOS] Fix tabs #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove fragile divider implementation & fix visible divider next to selected tab - correct tab body bg color (darkmode) - correct padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#154 introduced a slightly more visible little line next to selected tabs, and #155 broke the vertical alignment of the tabstrip to the tab body.
This fixes both, but also removes the previous fragile implementation of the divider lines as pipe characters, replacing them with a border and moving each tab's divider line to the right which allows the next tab's selection border to completely hide the divider (since tabs further to the right are above the previous ones on the z-axis)
Also corrected the body colour for dark mode.
Added a
:selected:pressedstate, but kept the dark mode colour deliberately more subtle than native MacOS, since Avalonia doesn't distinguish between 'already selected & then pressed' which is supposed to flash a clear "hey, I'm already selected!' colour, and 'pressed & becoming selected' which looks really jarring when the colour difference between the two states is too big.